fix: fix content width on pages without much content #1253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm torn between merging and closing this as |
github-actions
bot
added
the
t-tooling
B4nan
reviewed
Oct 15, 2024
Comment on lines
450
to
454
| @media (min-width: 1440px) { | ||
| .main-wrapper > div { | ||
| width: var(--max-layout-width); | ||
| } | ||
| } |
There was a problem hiding this comment.
What about adding width: 100%, without the media query? Looks good on my end locally.
There was a problem hiding this comment.
Huh, the tunnel vision is real 👀
width: 100% really does seem to work, desktops and mobile layouts alike. 👍🏽
B4nan
approved these changes
Oct 15, 2024
B4nan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Solves" misalignment on some pages with too little content.
Before:
After:
Peek.2024-10-15.13-11.mp4
The issue persists on mid-size desktop (laptop) screens—the fixed-width styling can only be applied on large enough displays; otherwise, the content gets obscured on other pages with actual content.
The moving sidebar is caused by not having enough content (vertically).